only add namespace if specified#1731
Merged
cdrage merged 1 commit intokubernetes:mainfrom Oct 11, 2023
Merged
Conversation
#### What type of PR is this? <!-- Add one of the following kinds: /kind cleanup /kind documentation /kind feature --> /kind bug #### What this PR does / why we need it: When we generate the YAML, we should NOT add namespace by default, namespace should only be added if it has been specified via the command line. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes kubernetes#1729 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AhmedGrati, cdrage The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only add namespace if specified
What type of PR is this?
/kind bug
What this PR does / why we need it:
When we generate the YAML, we should NOT add namespace by default,
namespace should only be added if it has been specified via the command
line.
Which issue(s) this PR fixes:
Fixes #1729
Special notes for your reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com