Closed
Conversation
Added a .travis.yml as well for testing Change-Id: Idf891e1bc4333e69da9535113702d802efd7993d
dims
pushed a commit
to dims/klog
that referenced
this pull request
Jan 25, 2019
Convert to structured log support
pohly
added a commit
to pohly/klog
that referenced
this pull request
Oct 16, 2023
Adding some dead code which calls fmt.Sprintf/Sprint/Sprintln makes "go vet" recognize what kind of parameters the unstructured klog calls take (https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-Analyzer_printf). Then it can report incorrect calls like: klog.Infof("%s") // k8s.io/klog/v2.Infof format %s reads arg kubernetes#1, but call has 0 args klog.Info("%s", "world") // k8s.io/klog/v2.Info call has possible formatting directive %s The same does not work for structured calls like klog.InfoS. logcheck needs to be used for those.
pohly
added a commit
to pohly/klog
that referenced
this pull request
Oct 23, 2023
Adding some dead code which calls fmt.Sprintf/Sprint/Sprintln makes "go vet" recognize what kind of parameters the unstructured klog calls take (https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-Analyzer_printf). Then it can report incorrect calls like: klog.Infof("%s") // k8s.io/klog/v2.Infof format %s reads arg kubernetes#1, but call has 0 args klog.Info("%s", "world") // k8s.io/klog/v2.Info call has possible formatting directive %s The same does not work for structured calls like klog.InfoS. logcheck needs to be used for those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a .travis.yml as well for testing
Change-Id: Idf891e1bc4333e69da9535113702d802efd7993d