kubernetes-csi release process#807
Merged
Merged
Conversation
msau42
reviewed
Feb 6, 2019
msau42
reviewed
Feb 8, 2019
Producing a combined release of all components no longer is a goal. Instead, each component gets released independently and CSI driver developers put together a combined deployment, similar to the example in the csi-driver-host-path repo.
Contributor
Author
|
@msau42 I've updated the KEP - no more combined release, "rc" tags explicitly mentioned, etc. Getting images published isn't supported well (or at all) in Prow at the moment, but it looks like there is a trick that is sufficient to test in a |
msau42
reviewed
Feb 14, 2019
msau42
reviewed
Feb 15, 2019
Contributor
Author
|
@msau42 updated once more. Do we need to find reviewers from other SIGs? |
This addresses the latest review feedback.
dbaa3b2 to
b4837fa
Compare
msau42
reviewed
Feb 19, 2019
Member
|
We should get another reviewer from sig-testing to make sure we can do the image pushing to gcr.io with Prow. @kubernetes/sig-testing-pr-reviews |
msau42
reviewed
Feb 19, 2019
Next round of review feedback updates.
mkumatag
suggested changes
Feb 20, 2019
Member
|
/lgtm |
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Feb 26, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
This was referenced Feb 26, 2019
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
Feb 26, 2019
This job is part of the plan for switching the kubernetes-csi release process from Travis CI to Prow. xref: kubernetes/enhancements#807 xref: kubernetes-csi/csi-driver-host-path#16
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 6, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 7, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 8, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
kzmrv
pushed a commit
to kzmrv/test-infra
that referenced
this pull request
Mar 12, 2019
This job is part of the plan for switching the kubernetes-csi release process from Travis CI to Prow. xref: kubernetes/enhancements#807 xref: kubernetes-csi/csi-driver-host-path#16
pohly
added a commit
to pohly/test-infra
that referenced
this pull request
Mar 13, 2019
We are in the process of enabling Prow testing for several repos in the kubernetes-csi organization (kubernetes/enhancements#807, kubernetes#11715). Instead of enabling the /test trigger individually for just the repos where it works and then remember to update it when adding new ones, it is simpler to just enable it for the entire org.
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 15, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807
pohly
added a commit
to pohly/csi-driver-host-path
that referenced
this pull request
Mar 26, 2019
prow.sh is a generic script that does unit and E2E testing inside a Prow job. xref: kubernetes/enhancements#807 This separates which kind of tests to run (serial/parallel, stable/alpha) from specifying what those tests are. Regular expressions for choosing tests only need to be specified once now, the actual focus and skip options are derived from that. Merging all junit files into one while throwing away the tests that we are not interested in increases load times in Spyglass. The implementation in Go is not as fancy as a XLST style sheet or an XPath-based filtering tool, but has the advantage that it works without introducing additional dependencies. csi-sanity testing is useful for CSI drivers. There's no longer a need to explicitly provide a configuration and deployment for the Kubernetes version that is being used for testing. Instead, the "latest" settings and deployment are used as fallback.
Member
|
/remove-sig architecture pm |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Contributor
Author
|
/remove-lifecycle stale |
Member
|
/lgtm |
msau42
reviewed
Sep 10, 2019
| editor: "@pohly" | ||
| creation-date: 2019-02-04 | ||
| last-updated: 2019-02-04 | ||
| status: provisional |
Member
There was a problem hiding this comment.
is it implementable/implemented?
Contributor
Author
There was a problem hiding this comment.
I think "provisional" is more suitable. The text should be updated once more to accommodate the latest proposal for image publishing from Prow (which just came in and is still pending in Kubernetes itself: kubernetes/test-infra#13332 (comment)); then it can be marked "implementable".
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, pohly, saad-ali The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets added as a KEP because the proposed solution will have to run on CNCF resources (Prow) and publish to the same destination as core Kubernetes (gcr.io). However, this proposal is independent of any particular Kubernetes release and thus does not need to be tracked.
/sig storage
/cc @msau42