Skip to content

[core]: introduce a common openstack client package#1384

Merged
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
kayrus:dedicated-client
Feb 15, 2021
Merged

[core]: introduce a common openstack client package#1384
k8s-ci-robot merged 6 commits intokubernetes:masterfrom
kayrus:dedicated-client

Conversation

@kayrus
Copy link
Copy Markdown
Contributor

@kayrus kayrus commented Jan 22, 2021

What this PR does / why we need it:

This PR optimizes the package structure. As an outcome some binary sizes are much smaller.

Which issue this PR fixes(if applicable):
fixes #993

Special notes for reviewers:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 22, 2021

Hi @kayrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 22, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 22, 2021

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jan 23, 2021

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 23, 2021

@kayrus: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/test cloud-provider-openstack-acceptance-test-keystone-authentication-authorization

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 23, 2021

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Jan 23, 2021

@lingxiankong @jichenjc ready for review

@jichenjc
Copy link
Copy Markdown
Contributor

jichenjc commented Jan 25, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 25, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 25, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Jan 25, 2021

Build succeeded.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build failed.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Feb 15, 2021

/test cloud-provider-openstack-acceptance-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2021

@kayrus: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-acceptance-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build failed.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Feb 15, 2021

/test cloud-provider-openstack-acceptance-test-lb-octavia

@kayrus
Copy link
Copy Markdown
Contributor Author

kayrus commented Feb 15, 2021

/test cloud-provider-openstack-e2e-test-csi-cinder

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2021

@kayrus: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-acceptance-test-lb-octavia

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 15, 2021

@kayrus: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cloud-provider-openstack-check
  • /test pull-cloud-provider-openstack-test

Use /test all to run all jobs.

Details

In response to this:

/test cloud-provider-openstack-e2e-test-csi-cinder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@ramineni
Copy link
Copy Markdown
Contributor

ramineni commented Feb 15, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci bot commented Feb 15, 2021

Build succeeded.

@k8s-ci-robot k8s-ci-robot merged commit 27b6fc4 into kubernetes:master Feb 15, 2021
@kayrus kayrus deleted the dedicated-client branch February 15, 2021 12:55
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
@kayrus
[core]: introduce a common openstack client package (kubernetes#1384)
869a366 
* [core]: introduce a common openstack client package

* [core]: less dependencies on "cloudprovider/providers/openstack" package

* [core]: move occm package to pkg dir

* Add os-endpoint-type into docs

* Adjust .zuul.yaml

* Rename files
@kayrus kayrus mentioned this pull request Mar 1, 2023
Closed
9 tasks
@kayrus kayrus mentioned this pull request Sep 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguslees anguslees Awaiting requested review from anguslees

@Fedosin Fedosin Awaiting requested review from Fedosin

@lingxiankong lingxiankong Awaiting requested review from lingxiankong

1 more reviewer

@ramineni ramineni ramineni left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lingxiankong lingxiankong

@ramineni ramineni

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move out OpenStack new client logic to a separate package

5 participants

@kayrus @k8s-ci-robot @jichenjc @lingxiankong @ramineni