Skip to content

Conversation

@kiwik
Copy link
Contributor

@kiwik kiwik commented Apr 10, 2018

What this PR does / why we need it:

Add periodic jobs for E2E conformance tests

  • test against kubernetes master
  • test against kubernetes latest release(v1.10.0)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #103

Special notes for your reviewer:
@dims

Release note:

- test against kubernetes master
- test against kubernetes latest release(v1.10.0)

Closes #103
@k8s-ci-robot k8s-ci-robot requested review from dixudx and rootfs April 10, 2018 01:56
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2018
@dixudx
Copy link
Member

dixudx commented Apr 10, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2018
@kiwik
Copy link
Contributor Author

kiwik commented Apr 10, 2018

Current supported trigger comments, we can rerun the failed test jobs with specific comments.
https://github.com/theopenlab/cicd-howto#kubernetescloud-provider-openstack

.zuul.yaml Outdated
- cloud-provider-openstack-acceptance-test-keystone-authentication-authorization
- cloud-provider-openstack-acceptance-test-lb-octavia
- cloud-provider-openstack-acceptance-test-e2e-conformance
- cloud-provider-openstack-acceptance-test-e2e-conformance-latest-release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename latest-release to stable-branch-1.10 please?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means we have to update this yaml file every time when we release a new branch ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dims , of course, stable-branch-1.10 is more exact, thank you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dixudx over time we will accumulate 3 of these (just like k8s supports 3 last branches) and we will have to drop the oldest one when we go beyond 3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dixudx yes, if we use explicit version job name, we have to update .zuul.yaml when k8s release; if we use current name, we only need to update OpenLab zuul job define.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2018

Zuul encountered a syntax error while parsing its configuration in the
repo kubernetes/cloud-provider-openstack on branch master. The error
was:

Job cloud-provider-openstack-acceptance-test-e2e-conformance-latest-release not defined

The error appears in the following project or project-template stanza:

project:
cloud-provider-openstack-all:
jobs:
- cloud-provider-openstack-unittest
- cloud-provider-openstack-acceptance-test-keystone-authentication-authorization
- cloud-provider-openstack-acceptance-test-lb-octavia
- cloud-provider-openstack-acceptance-test-e2e-conformance
- cloud-provider-openstack-acceptance-test-e2e-conformance-latest-release
cloud-provider-openstack-unit:
jobs:
- cloud-provider-openstack-unittest
cloud-provider-openstack-lb:
jobs:
- cloud-provider-openstack-acceptance-test-lb-octavia
cloud-provider-openstack-auth:
jobs:
- cloud-provider-openstack-acceptance-test-keystone-authentication-authorization
cloud-provider-openstack-e2e-conformance:
jobs:
- cloud-provider-openstack-acceptance-test-e2e-conformance
- cloud-provider-openstack-acceptance-test-e2e-conformance-latest-release
periodic:
jobs:
- cloud-provider-openstack-acceptance-test-e2e-conformance
- cloud-provider-openstack-acceptance-test-e2e-conformance-latest-release

in "kubernetes/cloud-provider-openstack/.zuul.yaml@master", line 1, column 3

@kiwik
Copy link
Contributor Author

kiwik commented Apr 10, 2018

/test cloud-provider-openstack-e2e-conformance

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2018

@kiwik
Copy link
Contributor Author

kiwik commented Apr 10, 2018

Ready to go

@dims
Copy link
Member

dims commented Apr 10, 2018

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2018
@dims
Copy link
Member

dims commented Apr 10, 2018

/test all

@dims
Copy link
Member

dims commented Apr 10, 2018

/test cloud-provider-openstack-all

@dims
Copy link
Member

dims commented Apr 10, 2018

/retest
/test all

@mrhillsman
Copy link
Contributor

/test all

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2018

@dims
Copy link
Member

dims commented Apr 10, 2018

/test all

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 10, 2018

@dims
Copy link
Member

dims commented Apr 10, 2018

/test all

@theopenlab-ci
Copy link

theopenlab-ci bot commented Apr 11, 2018

@dims
Copy link
Member

dims commented Apr 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c6a365 into kubernetes:master Apr 11, 2018
@kiwik kiwik deleted the add-periodic-e2e-jobs branch April 11, 2018 06:18
powellchristoph pushed a commit to powellchristoph/cloud-provider-openstack that referenced this pull request Jan 19, 2022
Add periodic jobs for E2E conformance tests
dulek pushed a commit to dulek/cloud-provider-openstack that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a periodic job for e2e conformance test and upload results to test grid

5 participants