This repository was archived by the owner on Sep 9, 2020. It is now read-only.
Add --override to env targets cli#865
Merged
underrun merged 1 commit intoksonnet:masterfrom Sep 19, 2018
Merged
Conversation
Pull Request Test Coverage Report for Build 1345
💛 - Coveralls |
shomron
approved these changes
Sep 19, 2018
Collaborator
shomron
left a comment
There was a problem hiding this comment.
One delete-a-comment, the rest looks good 👍.
pkg/app/base_app.go
Outdated
| spec.Targets = targets | ||
|
|
||
| isOverride := ba.IsEnvOverride(envName) | ||
| //isOverride := ba.IsEnvOverride(envName) |
cc0f930 to
d268d2c
Compare
to bring them in line with env set and env add operations on override environments. also fixes e2e tests for new behavior. Signed-off-by: Derek Wilson <derek@heptio.com>
d268d2c to
ede3eea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To bring them in line with env set and env add operations on override environments.
closes #857