Skip to content
This repository was archived by the owner on Sep 9, 2020. It is now read-only.

Ensure registry paths exist before adding them#601

Merged
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:registry-invalid-path
Jun 15, 2018
Merged

Ensure registry paths exist before adding them#601
bryanl merged 1 commit intoksonnet:masterfrom
bryanl:registry-invalid-path

Conversation

@bryanl
Copy link
Member

@bryanl bryanl commented Jun 10, 2018

  • Fs: check the filesystem path exists
  • GitHub: check if registry.yaml is available

Fixes #591

Signed-off-by: bryanl bryanliles@gmail.com

@bryanl bryanl requested a review from a team June 10, 2018 14:50
@coveralls
Copy link

coveralls commented Jun 10, 2018

Pull Request Test Coverage Report for Build 965

  • 37 of 39 (94.87%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 69.758%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/registry/fs.go 9 11 81.82%
Totals Coverage Status
Change from base Build 961: 0.003%
Covered Lines: 9672
Relevant Lines: 13865

💛 - Coveralls

@bryanl bryanl force-pushed the registry-invalid-path branch from ec17aa1 to cd7c01c Compare June 10, 2018 15:06
* Fs: check the filesystem path exists
* GitHub: check if registry.yaml is available

Fixes ksonnet#591

Signed-off-by: bryanl <bryanliles@gmail.com>
@bryanl bryanl force-pushed the registry-invalid-path branch from cd7c01c to fa791a6 Compare June 10, 2018 15:25
@bryanl bryanl added the bug label Jun 12, 2018
@bryanl
Copy link
Member Author

bryanl commented Jun 14, 2018

/ping

@bryanl bryanl merged commit 6e2980c into ksonnet:master Jun 15, 2018
@bryanl bryanl deleted the registry-invalid-path branch June 15, 2018 19:23
shomron added a commit to shomron/ksonnet that referenced this pull request Jun 18, 2018
Fixes over-restrictive validation from ksonnet#601

Signed-off-by: Oren Shomron <shomron@gmail.com>
shomron added a commit to shomron/ksonnet that referenced this pull request Jun 18, 2018
Fixes over-restrictive validation from ksonnet#601

Signed-off-by: Oren Shomron <shomron@gmail.com>
shomron added a commit to shomron/ksonnet that referenced this pull request Jun 18, 2018
Fixes over-restrictive validation from ksonnet#601

Signed-off-by: Oren Shomron <shomron@gmail.com>

Renaming [Registry|Library]RefSpec -> [Registry|Library]Config

Signed-off-by: Oren Shomron <shomron@gmail.com>

WIP

WIP

WIP

compiles

Now functional

tests

more tests

rename

rename test

Fix rebase conflicts

remove commented code

merge conflicts

regenerate mocks

Call Validate for mocks

fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants