Fix race condition in formatting-settings.test.ts #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Though we await `executeCommand` in these tests before checking the document for the command's changes, the document itself could be stale and we ran into a failure where we lost this race. Fix this by re-fetching the document from the workspace every time rather than caching a direct reference to it.
Errand auto-generated lock file changes
Collaborator
|
What this the cause of those spurious errors in CI? If so, I'm glad it's solved! |
holodorum
pushed a commit
that referenced
this pull request
Nov 18, 2025
Fix race condition in formatting-settings.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though we await
executeCommandin these tests before checking the document for the command's changes, the document itself could be stale and we ran into a failure where we lost this race. Fix this by re-fetching the document from the workspace every time rather than caching a direct reference to it.