Added size and colour parameters to UI.Message()#499
Closed
Somfic wants to merge 5 commits intokrpc:masterfrom
Somfic:master
Closed
Added size and colour parameters to UI.Message()#499Somfic wants to merge 5 commits intokrpc:masterfrom Somfic:master
Somfic wants to merge 5 commits intokrpc:masterfrom
Somfic:master
Conversation
Changed using namespace to UnityEngine instead of System.Drawing
Contributor
Author
|
Namespaces cannot be added - closed. |
Member
|
I don't follow why you abandoned this. What went wrong? |
Contributor
Author
|
Travis Ci kept giving namespace errors |
djungelorm
added a commit
that referenced
this pull request
Oct 7, 2018
Member
|
I managed to get it to work - see the commit above. I used a slightly esoteric kRPC feature to allow color to be treated as a default parameter (using KRPCDefaultValue to work around the C# limitation that you can't have an object as the default value) I also reordered the parameters to put the new color and size parameters at the end, to maintain backwards compatibility for older code. |
Contributor
Author
|
That's great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds parameters to change the default size and colour of messages when using UI.Message().
Added the size and color parameter, modified the summary as well.