cnano clients boudrate is adjustable now#487
Closed
tilegg wants to merge 1 commit intokrpc:masterfrom
Closed
Conversation
Updated cnano client so the boudrate can be adjusted via the arg-param.
djungelorm
added a commit
that referenced
this pull request
Aug 9, 2018
…of type krpc_connection_config_t to allow additional configuration options to be passed, such as baud rate for Arduino serial port (#487)
Member
|
Thanks for the PR, however your implementation is not backwards compatible, and doesn't allow setting other serial port parameters such as the data, parity and stop bits. I have made some changes to add these features in a backwards compatible manner here: ad7d534 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated cnano client so the boudrate can be adjusted via the arg-param.