Skip to content

Add of marks#1

Closed
lock042 wants to merge 2 commits intokristapsdz:masterfrom
lock042:marks
Closed

Add of marks#1
lock042 wants to merge 2 commits intokristapsdz:masterfrom
lock042:marks

Conversation

@lock042
Copy link
Copy Markdown

@lock042 lock042 commented Sep 27, 2016

Added the ability to use KPLOT_MARKS and KPLOT_LINESMARKS

@kristapsdz
Copy link
Copy Markdown
Owner

kristapsdz commented Sep 29, 2016

I'm reviewing your patch (looks very straightforward)---but meanwhile, do you have any exemplar graph pictures of this in action? Also, you'll need to patch the mdoc documentation to describe the new interface options. (Should be pretty easy, considering you've done all the hard work already!)

@lock042
Copy link
Copy Markdown
Author

lock042 commented Oct 1, 2016

Hello.

Do you mean here: https://github.com/lock042/kplot/tree/marks/man ?

kristapsdz pushed a commit that referenced this pull request Nov 3, 2016
some manpage updates and an example implementing the new marks.
@kristapsdz
Copy link
Copy Markdown
Owner

Finally checked all this in. Thanks again!

@kristapsdz kristapsdz closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants