fix: address framework issues from first session#1
Merged
kraulerson merged 1 commit intomainfrom Apr 6, 2026
Merged
Conversation
- branch-safety.sh: expand regex to catch `gh repo create --push` and `gh pr merge` in addition to `git push` - CLAUDE.md: add step-sequencing instruction — follow numbered steps in order, don't infer completion from local state - Builder's Guide: add "remote repo exists" and "branch protection configured" to Phase 2 init verification checklist - Desktop Platform Module: add Section 3.4 documenting Nuitka + large native package hang and Python version compatibility chain Includes regression test for branch-safety.sh pattern matching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
40a8125 to
fd00ea4
Compare
kraulerson
pushed a commit
that referenced
this pull request
Apr 6, 2026
Merge commits (e.g., "Merge pull request #1 from user/fix/branch") contain branch names with "fix" in the message but have no file list in git log --name-only output. The hook matched "fix" in the message, found no test files (because merge commits list none), and flagged a false positive. Fix: skip commits whose message starts with "Merge " when scanning for untested bug fixes. Includes documentation of the root cause analysis in docs/framework-feedback/stop-hook-test-detection.md. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
kraulerson
pushed a commit
that referenced
this pull request
Apr 6, 2026
Merge commits (e.g., "Merge pull request #1 from user/fix/branch") contain branch names with "fix" in the message but have no file list in git log --name-only output. The hook matched "fix" in the message, found no test files (because merge commits list none), and flagged a false positive. Fix: skip commits whose message starts with "Merge " when scanning for untested bug fixes. Includes regression tests verifying the detection logic for both real fix commits and merge commits. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
branch-safety.shto catchgh repo create --pushandgh pr mergebypassing branch protectionTest plan
branch-safety.shblocksgh repo create --pushon protected branches🤖 Generated with Claude Code