Skip to content

Only fail on error, add option to ignore warnings#120

Merged
krampstudio merged 2 commits into
krampstudio:0.6.xfrom
Raynes:errors
May 24, 2015
Merged

Only fail on error, add option to ignore warnings#120
krampstudio merged 2 commits into
krampstudio:0.6.xfrom
Raynes:errors

Conversation

@Raynes

@Raynes Raynes commented Feb 21, 2015

Copy link
Copy Markdown
Contributor

This pull request extends on the error checking a bit to ignore
warnings. Warnings do not necessitate a complete failure. For example,
with ES6, you're gonna get warnings about new stuff no matter what –
you can still generate docs!

Furthermore, added an ignoreWarnings option to not print warnings.

This pull request extends on the error checking a bit to ignore
warnings. Warnings do not necessitate a complete failure. For example,
with ES6, you're gonna get warnings about new stuff no matter what –
you can still generate docs!

Furthermore, added an ignoreWarnings option to not print warnings.
@krampstudio

Copy link
Copy Markdown
Owner

Isn't the role of the force flag to ignore warnings ?

@Raynes

Raynes commented Feb 27, 2015

Copy link
Copy Markdown
Contributor Author

Yes, but the way this is being done makes no sense. It's failing immediately on warnings. Warnings in jsdoc and warnings in grunt are two different things. Most importantly, even if you --force, you don't see all the warnings and errors. jsdoc doesn't even die during errors, it keeps going and shows you all of them. I mostly just want all of the output, warnings included.

@simonomis

Copy link
Copy Markdown

This feature would be really useful for me too. I'm writing ES6 modules and because I have to use force I'm missing genuine jsdoc errors because the exit status is always 0. Being able to ignore warnings (because they are almost always about ES6 import/export nodes) but still fail on errors would be very helpful at least until all ES6 syntax is fully supported.

@krampstudio krampstudio self-assigned this Mar 20, 2015
@krampstudio

Copy link
Copy Markdown
Owner

I'll merge it as soon as I have some time to do it.

krampstudio added a commit that referenced this pull request May 24, 2015
Only fail on error, add option to ignore warnings
@krampstudio krampstudio merged commit c08d2f6 into krampstudio:0.6.x May 24, 2015
@krampstudio

Copy link
Copy Markdown
Owner

Merged but I need to handle the ignoreWarning option and do some testing before publishing to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants