Skip to content

write release notes to current dir to avoid goreleaser --clean deleting them#700

Merged
sami-alajrami merged 1 commit intomainfrom
fix-release-with-notes
Mar 13, 2026
Merged

write release notes to current dir to avoid goreleaser --clean deleting them#700
sami-alajrami merged 1 commit intomainfrom
fix-release-with-notes

Conversation

@sami-alajrami
Copy link
Contributor

No description provided.

@sami-alajrami sami-alajrami enabled auto-merge (squash) March 13, 2026 15:50
printf '%s' "$BODY" > dist/release_notes.md
echo "args=--release-notes=dist/release_notes.md" >> $GITHUB_OUTPUT
printf '%s' "$BODY" > release_notes.md
echo "args=--release-notes=release_notes.md" >> $GITHUB_OUTPUT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker here, but we should use CHANGELOG.md which seems to be more standard was collating those in a repo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Marko, we also have a skill that supports it:
https://github.com/kosli-dev/skills/blob/main/documentation/changelog-creator/SKILL.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is not persisted in the repo at the moment. We may update the process to have it persisted and name it Changelog.md

@sami-alajrami sami-alajrami merged commit 41f59a0 into main Mar 13, 2026
9 checks passed
@sami-alajrami sami-alajrami deleted the fix-release-with-notes branch March 13, 2026 15:56
github-actions bot pushed a commit that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants