Skip to content

DirectGL on Win32. Hugely reduces OpenGL overhead on windows JVM: Use JNA 5.13 Library.OPTION_SYMBOL_PROVIDER to implement fast direct OpenGL mapping on Windows#1195

Merged
soywiz merged 1 commit intomainfrom
feature/use.direct.jna.mapping.on.win32.retake
Jan 14, 2023
Merged

Conversation

@soywiz
Copy link
Copy Markdown
Contributor

@soywiz soywiz commented Jan 14, 2023

Since JNA 5.13 we have this: java-native-access/jna#1490

Superseeds #1140 without the need of custom JNA binaries

See https://github.com/java-native-access/jna/blob/master/www/DirectMapping.md

@soywiz soywiz mentioned this pull request Jan 14, 2023
Closed
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 14, 2023

Codecov Report

Base: 54.13% // Head: 54.12% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (972037a) compared to base (4f5e84e).
Patch coverage: 6.66% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   54.13%   54.12%   -0.01%     
==========================================
  Files        1822     1822              
  Lines      121304   121315      +11     
  Branches    18692    18693       +1     
==========================================
- Hits        65668    65667       -1     
- Misses      50406    50413       +7     
- Partials     5230     5235       +5
Flag Coverage Δ
unittests 54.12% <6.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Main/kotlin/com/soywiz/korgw/platform/INativeGL.kt 0.00% <0.00%> (ø)
...vmMain/kotlin/com/soywiz/korgw/win32/Win32Tools.kt 0.00% <0.00%> (ø)
...Main/kotlin/com/soywiz/korgw/platform/NativeKgl.kt 0.66% <100.00%> (ø)
...mmonTest/kotlin/com/soywiz/korio/vfs/ZipVfsTest.kt 76.92% <0.00%> (-8.80%) ⬇️
...com/soywiz/korim/text/RichTextDataPlacementTest.kt 75.00% <0.00%> (-8.34%) ⬇️
.../kotlin/com/soywiz/korau/format/AudioFormatTest.kt 92.00% <0.00%> (-8.00%) ⬇️
...Test/kotlin/com/soywiz/korge/view/NinePatchTest.kt 95.91% <0.00%> (-4.09%) ⬇️
...onTest/kotlin/com/soywiz/korio/vfs/LocalVfsTest.kt 68.33% <0.00%> (-3.34%) ⬇️
...c/commonMain/kotlin/com/soywiz/korau/format/OGG.kt 70.21% <0.00%> (-2.13%) ⬇️
...est/kotlin/com/soywiz/korim/font/TtfCIDFontTest.kt 95.91% <0.00%> (-2.05%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soywiz soywiz merged commit 67c38ab into main Jan 14, 2023
@soywiz soywiz deleted the feature/use.direct.jna.mapping.on.win32.retake branch October 4, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soywiz @codecov-commenter