Skip to content

Cobble a PocketBook TC together#22

Merged
NiLuJe merged 11 commits intokoreader:masterfrom
NiLuJe:master
Feb 15, 2020
Merged

Cobble a PocketBook TC together#22
NiLuJe merged 11 commits intokoreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe
Copy link
Copy Markdown
Member

@NiLuJe NiLuJe commented Feb 13, 2020

Following a discussion on gitter a couple weeks ago ;).

The TC builds, it builds KOReader without issue, and it apparently "works".


This change is Reviewable

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Feb 14, 2020

w00t, now the PB image can shrink some 400 MB \m/

(The @#@#$# hacks/incompatibilities with gcc 4.8 are the real win obviously, but still. ;-) )

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Feb 14, 2020

But seriously, this is f-in' lit. ^_^ Including the header mod part, hehe.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Feb 14, 2020

Yeah, this made me realize that the SDK was shipping a lot of crap... That might have been causing all sorts of trouble because it happens to be old crap, to boot ^^.


FWIW, the latest round of updates should be the final one, if you find some time to work on the docker image before the actual merge ;).


I diff'ed the headers against the "new" SDK, we don't appear to be missing out on much, so I stayed with the final "old" ones to avoid any more surprises.
Someone with an actual PB device might want to look into it if that ends up being an issue down the road ;).

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Feb 14, 2020

Yeah, this made me realize that the SDK was shipping a lot of crap...

I already cut the bulk of it out, see https://github.com/koreader/virdevenv/blob/7ae6c51944269d33e4917da221d84da6a7f0fc24/docker/ubuntu/kopb/Dockerfile#L10 (those locales are many hundreds of MB) but I didn't really want to spend time figuring out what else I could safely cut for a few 100 MB less.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Feb 14, 2020

Btw, here are the savings:

Screenshot_2020-02-14_23-29-00

@NiLuJe NiLuJe merged commit 711acc4 into koreader:master Feb 15, 2020
Frenzie added a commit to koreader/virdevenv that referenced this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants