fix: SDL3 HiDPI return value check#2285
Merged
Merged
Conversation
benoit-pierre
requested changes
Mar 5, 2026
SDL3's SDL_GetCurrentRenderOutputSize returns bool (true=success), not int (0=success) like SDL2's SDL_GetRendererOutputSize. The == 0 check skips the HiDPI codepath on success, causing blurry rendering on HiDPI displays like macos Retina
34dae59 to
6f38f0a
Compare
benoit-pierre
approved these changes
Mar 5, 2026
benoit-pierre
pushed a commit
to benoit-pierre/koreader
that referenced
this pull request
Mar 5, 2026
SDL3's SDL_GetCurrentRenderOutputSize returns bool (true=success), not int (0=success) like SDL2's SDL_GetRendererOutputSize. The == 0 check skips the HiDPI codepath on success, causing blurry rendering on HiDPI displays like macos Retina
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Mar 6, 2026
- zlib: minor build simplification (koreader/koreader-base#2282) - sdl: build our version for the linux target (koreader/koreader-base#2283) - fix: SDL3 HiDPI return value check (koreader/koreader-base#2285) - sdl: ensure we have a recent enough version (koreader/koreader-base#2288) - make: tweak setup target (koreader/koreader-base#2289) - sdl: enable mouse focus click-through (koreader/koreader-base#2291) - luajit: update to 2.1.1772619647 (koreader/koreader-base#2292)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Mar 6, 2026
- zlib: minor build simplification (koreader/koreader-base#2282) - sdl: build our version for the linux target (koreader/koreader-base#2283) - fix: SDL3 HiDPI return value check (koreader/koreader-base#2285) - sdl: ensure we have a recent enough version (koreader/koreader-base#2288) - make: tweak setup target (koreader/koreader-base#2289) - sdl: enable mouse focus click-through (koreader/koreader-base#2291) - luajit: update to 2.1.1772619647 (koreader/koreader-base#2292)
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- zlib: minor build simplification (koreader/koreader-base#2282) - sdl: build our version for the linux target (koreader/koreader-base#2283) - fix: SDL3 HiDPI return value check (koreader/koreader-base#2285) - sdl: ensure we have a recent enough version (koreader/koreader-base#2288) - make: tweak setup target (koreader/koreader-base#2289) - sdl: enable mouse focus click-through (koreader/koreader-base#2291) - luajit: update to 2.1.1772619647 (koreader/koreader-base#2292)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDL3's SDL_GetCurrentRenderOutputSize returns bool (true=success), not int (0=success) like SDL2's SDL_GetRendererOutputSize. The == 0 check skips the HiDPI codepath on success, causing blurry rendering on HiDPI displays like macos Retina.
Close #2284.
This change is