Fix offs_x/offs_y typo in BB_add_blit_from fast path#2266
Merged
Conversation
The alpha == 0xFF fast path passed offs_x as both the x and y offset to BB_blit_to, causing out-of-bounds reads.
benoit-pierre
approved these changes
Feb 13, 2026
benoit-pierre
pushed a commit
to benoit-pierre/koreader
that referenced
this pull request
Feb 17, 2026
…er-base#2266) The alpha == 0xFF fast path passed offs_x as both the x and y offset to BB_blit_to, causing out-of-bounds reads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
alpha == 0xFFfast path inBB_add_blit_frompassesoffs_xas both the x and y source offset toBB_blit_to:This causes out-of-bounds reads whenever
offs_x != offs_y, which can lead to crashes or visual corruption.This change is