Support PageSnapshot() function#2247
Merged
Merged
Conversation
This function allows setting current page as the boot logo on Pocketbooks. See https://github.com/reuerendo/pocketbooktools.koplugin for a sample usage. The function is defined in https://github.com/pocketbook/SDK_6.3.0/blob/dd8de463733a2bc0d53d1214b64734586fac427e/SDK-B288/usr/arm-obreey-linux-gnueabi/sysroot/usr/local/include/inkview.h#L2854.
Member
|
I assume that should also be added here. ;-) koreader-base/ffi-cdecl/inkview_decl.c Lines 205 to 206 in 5d25a29 |
Contributor
Author
|
Oops, my bad. |
Member
|
See #2248 for updated instructions. |
Contributor
Author
Is it correct now? |
Member
|
Nope :P, after updating |
Member
|
And please keep the cdecls alphabetically sorted. |
Contributor
Author
|
Done. |
benoit-pierre
approved these changes
Jan 6, 2026
benoit-pierre
pushed a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 6, 2026
) This function allows setting current page as the boot logo on Pocketbooks. See https://github.com/reuerendo/pocketbooktools.koplugin for a sample usage. The function is defined in https://github.com/pocketbook/SDK_6.3.0/blob/dd8de463733a2bc0d53d1214b64734586fac427e/SDK-B288/usr/arm-obreey-linux-gnueabi/sysroot/usr/local/include/inkview.h#L2854.
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 18, 2026
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Jan 18, 2026
- koreader/koreader-base#2247 - koreader/koreader-base#2248 - koreader/koreader-base#2249 - koreader/koreader-base#2250 - koreader/koreader-base#2251 - koreader/koreader-base#2252 - koreader/koreader-base#2253 - koreader/koreader-base#2254 - koreader/koreader-base#2255 - koreader/koreader-base#2256 (close koreader#14841)
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Jan 18, 2026
- koreader/koreader-base#2247 - koreader/koreader-base#2248 - koreader/koreader-base#2249 - koreader/koreader-base#2250 - koreader/koreader-base#2251 - koreader/koreader-base#2252 - koreader/koreader-base#2253 - koreader/koreader-base#2254 - koreader/koreader-base#2255 - koreader/koreader-base#2256 (close #14841)
Contributor
|
@dmalinovsky fyi I opened koreader/koreader#15124 to potentially utilise this in upstream KOReader — seemed weird to do this in the pocketbooksync plugin when it's a simple PageSnapshot call in onSuspend :-) |
Contributor
Author
|
@liskin, nice, I'll have one less patch to apply this way! :) |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- koreader/koreader-base#2247 - koreader/koreader-base#2248 - koreader/koreader-base#2249 - koreader/koreader-base#2250 - koreader/koreader-base#2251 - koreader/koreader-base#2252 - koreader/koreader-base#2253 - koreader/koreader-base#2254 - koreader/koreader-base#2255 - koreader/koreader-base#2256 (close koreader#14841)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function allows setting current page as the boot logo on Pocketbooks. See https://github.com/reuerendo/pocketbooktools.koplugin for a sample usage.
The function is defined in https://github.com/pocketbook/SDK_6.3.0/blob/dd8de463733a2bc0d53d1214b64734586fac427e/SDK-B288/usr/arm-obreey-linux-gnueabi/sysroot/usr/local/include/inkview.h#L2854.
This change is