cmake: add targets for generating FFI cdecls#2027
Merged
Merged
Conversation
Tweak "Automatically generated with…" header to avoid absolute paths (resulting in differences when the base / build directory is different).
- correctly handle `-o output` - don't write to / overwrite output if the GCC call failed
Nothing major except merging `ffi/custom_input_h` into `ffi/linux_input_h.lua`.
Member
|
Ah yes, the Gtk filechooser. Pity it broke. #631 I don't recall if I added drag & drop before or after, but the filechooser seemed a bit redundant to me by the time it unfortunately broke due to incompatible Gtk changes. |
Member
Author
I think this days a better alternative would be something like the XDG desktop portal mechanism. |
Member
|
Probably, yes. |
NiLuJe
approved these changes
Jan 29, 2025
benoit-pierre
added a commit
to benoit-pierre/koreader
that referenced
this pull request
Feb 22, 2025
- koreader/koreader-base#2024 - koreader/koreader-base#2025 - koreader/koreader-base#2026 - koreader/koreader-base#2027 - koreader/koreader-base#2028 - koreader/koreader-base#2029 - koreader/koreader-base#2030 - koreader/koreader-base#2031 - koreader/koreader-base#2032 - koreader/koreader-base#2033 - koreader/koreader-base#2034 - koreader/koreader-base#2035 - koreader/koreader-base#2036 - koreader/koreader-base#2037 - koreader/koreader-base#2038 - koreader/koreader-base#2040
Frenzie
pushed a commit
to koreader/koreader
that referenced
this pull request
Feb 22, 2025
- koreader/koreader-base#2024 - koreader/koreader-base#2025 - koreader/koreader-base#2026 - koreader/koreader-base#2027 - koreader/koreader-base#2028 - koreader/koreader-base#2029 - koreader/koreader-base#2030 - koreader/koreader-base#2031 - koreader/koreader-base#2032 - koreader/koreader-base#2033 - koreader/koreader-base#2034 - koreader/koreader-base#2035 - koreader/koreader-base#2036 - koreader/koreader-base#2037 - koreader/koreader-base#2038 - koreader/koreader-base#2040
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
- koreader/koreader-base#2024 - koreader/koreader-base#2025 - koreader/koreader-base#2026 - koreader/koreader-base#2027 - koreader/koreader-base#2028 - koreader/koreader-base#2029 - koreader/koreader-base#2030 - koreader/koreader-base#2031 - koreader/koreader-base#2032 - koreader/koreader-base#2033 - koreader/koreader-base#2034 - koreader/koreader-base#2035 - koreader/koreader-base#2036 - koreader/koreader-base#2037 - koreader/koreader-base#2038 - koreader/koreader-base#2040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, after a MuPDF update:
make mupdf-ffito regenerateffi/mupdf_h.lua. Ormake linux-ffito regenerateffi/einkfb_h.lua,ffi/inotify_h.lua,ffi/linux_fb_h.lua,ffi/linux_input_h.luaandffi/rtc_h.lua.Alternatively
make koptcontext_h.luato regenerateffi/koptcontext_h.lua(can't have/in target names…), ormake ffito generate all applicable cdecls for the currentTARGET.Notable exceptions:
posix_h.lua,pthread_h.lua, andinkview_h.luamxcfb_sony_h.lua: the declarations inffi-cdecl/mxcfb_sony_decl.candffi-cdecl/include/mxcfb-sony.hdon't match withffi/mxcfb_sony_h.lua? (e.g.: noWAVEFORM_MODE_DU)This change is