Skip to content

always compile with debug information#2022

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/always_compile_with_debug_information
Jan 26, 2025
Merged

always compile with debug information#2022
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/always_compile_with_debug_information

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jan 26, 2025

Copy link
Copy Markdown
Member

Each binary's debug information are extracted and linked to a separate .dbg file. Those .dbg files are ignored when bundling a release, but otherwise transparently used by gdb, addr2line, and other tools when present.


This change is Reviewable

Each binary's debug information are extracted and linked to a separate
`.dbg` file. Those `.dbg` files are ignored when bundling a release,
but otherwise transparently used by gdb, addr2line, and other tools
when present.
@benoit-pierre

Copy link
Copy Markdown
Member Author

Note: for macOS, dsymutil is used to split the debug information into a separate .dSYM bundle that should work the same (untested, as I don't have access to a machine for checking).

@Frenzie

Frenzie commented Jan 26, 2025

Copy link
Copy Markdown
Member

I suppose it might be a tad slower to build, but the runtime performance is identical?

@benoit-pierre

Copy link
Copy Markdown
Member Author

Yep.

@Frenzie Frenzie merged commit d198818 into koreader:master Jan 26, 2025
@benoit-pierre benoit-pierre deleted the pr/always_compile_with_debug_information branch January 26, 2025 19:03
benoit-pierre added a commit to benoit-pierre/koreader that referenced this pull request Jan 26, 2025
Frenzie pushed a commit to koreader/koreader that referenced this pull request Jan 27, 2025
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request Jan 27, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants