Skip to content

cmake: fix cleaning an external project source tree#2019

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/fix_source_tree_cleanup
Jan 12, 2025
Merged

cmake: fix cleaning an external project source tree#2019
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/fix_source_tree_cleanup

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jan 12, 2025

Copy link
Copy Markdown
Member

Cleaning directories need to be done in reverse order.


This change is Reviewable

Cleaning directories need to be done in reverse order.
@benoit-pierre

Copy link
Copy Markdown
Member Author

Cf. #1984 (comment).

@poire-z poire-z left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solved my issue, bravo!

@Frenzie Frenzie merged commit c5e24c9 into koreader:master Jan 12, 2025
@benoit-pierre benoit-pierre deleted the pr/fix_source_tree_cleanup branch January 12, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants