Skip to content

build sdl2 for appimage#1946

Merged
Frenzie merged 2 commits into
koreader:masterfrom
benoit-pierre:pr/build_sdl2_for_appimage
Oct 1, 2024
Merged

build sdl2 for appimage#1946
Frenzie merged 2 commits into
koreader:masterfrom
benoit-pierre:pr/build_sdl2_for_appimage

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Sep 30, 2024

Copy link
Copy Markdown
Member

Getting an updated version fix an issue with some erroneous key events being processed when using a X11 window manager:

  • start KOReader on a virtual desktop, say the first one
  • switch to another desktop, and back using the WM shortcut (Super+1)
  • on getting back focus, KOReader somehow end up processing a 1 key press event, jumping to the beginning of the current book

Note: will need an updated koappimage docker image.


This change is Reviewable

Getting an updated version fix an issue with some erroneous
key events being processed when using a X11 window manager:
- start KOReader on a virtual desktop, say the first one
- switch to another desktop, and back using the WM shortcut
  (`Super+1`)
- on getting back focus, KOReader somehow end up processing
  a `1` key press event, jumping to the beginning of the
  current book

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NiLuJe any comments?

@NiLuJe

NiLuJe commented Oct 1, 2024

Copy link
Copy Markdown
Member

Nope, sounds good ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants