Skip to content

MuPDF: Unbreak RGB->BGR swap#1808

Merged
Frenzie merged 2 commits into
koreader:masterfrom
NiLuJe:master
Jun 1, 2024
Merged

MuPDF: Unbreak RGB->BGR swap#1808
Frenzie merged 2 commits into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented Jun 1, 2024

Copy link
Copy Markdown
Member

fz_default_color_params is no longer a function, but a plain constant.

Regression since #1805

Re: koreader/koreader#11952


This change is Reviewable

fz_default_color_params is no longer a function, but a plain constant.

Regression since koreader#1805

Re: koreader/koreader#11952
@NiLuJe

This comment was marked as outdated.

@jospalau

jospalau commented Jun 1, 2024

Copy link
Copy Markdown

Commenting the line self.hasBGRFrameBuffer = yes in device.lua for Kobo makes it work. Thanks

@NiLuJe

NiLuJe commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

Another random query, as I'm unfamiliar with the whole thing: fz_convert_pixmap can throw, should it be wrapped in one our our wrap-mupdf.h wrappers?

@NiLuJe

NiLuJe commented Jun 1, 2024

Copy link
Copy Markdown
Member Author

Eh, wrapped it.

Also, tested it now ;p.

Which means I had my first new buildsystem experience: she goes!

- Real: 64.51s User: 551.75s System: 87.05s Percent: 990% Cmd: ./kodev build MajFault: 867 VolContSw: 265299 InvContSw: 176338

(Add ~10s for a clean clone, this was a rebuild so the sources were downloaded already).

(And there's still potentially a lot of headroom for more //, as it's a 32 threads machine, so that 990% could theoretically go as high as 3200%. Emphasis on "theoretically": I run Gentoo, so I'm aware that you'd have to push pretty hard to saturate it, unless you're building something gigantic ;)).

Kudos @benoit-pierre ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants