Add C declarations needed for zmq http server#1595
Merged
Conversation
Frenzie
reviewed
Apr 8, 2023
Comment on lines
+116
to
+117
| int zmq_send(void *, void *, size_t, int); | ||
| int zframe_send(zframe_t **, void *, int); |
Member
There was a problem hiding this comment.
Not the biggest deal but these seem to be in the "wrong" location compared to their definition?
Frenzie
approved these changes
Apr 8, 2023
Member
|
LGTM besides the ordering nit mentioned above (which will make diff'ing further updates confusing, so, yeah, please fix it ;)). |
Contributor
Author
|
Whoops, should be fixed now |
Frenzie
reviewed
Apr 9, 2023
Comment on lines
119
to
-115
| cdecl_func(zhash_lookup) | ||
| cdecl_func(zmsg_destroy) | ||
| cdecl_func(zhash_destroy) | ||
| cdecl_func(zframe_destroy) |
Member
There was a problem hiding this comment.
It looks like all the destroys are purposefully together. You prefer them as all the zframes together?
Contributor
Author
There was a problem hiding this comment.
There is other destroys that are grouped with their own class functions. I'll move the other destroys to their own groups. So all functions to be grouped by their class (zhash, zctx, zframe etc.)
NiLuJe
approved these changes
Apr 9, 2023
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Apr 16, 2023
Includes: * Fix build on Mac OS X 13.3+ (missing ifr_netmask) (koreader/koreader-base#1596) * Add C declarations needed for zmq http server (koreader/koreader-base#1595) * SDL: add multitouch support (koreader/koreader-base#1599)
Frenzie
added a commit
to koreader/koreader
that referenced
this pull request
Apr 16, 2023
Includes: * Fix build on Mac OS X 13.3+ (missing ifr_netmask) (koreader/koreader-base#1596) * Add C declarations needed for zmq http server (koreader/koreader-base#1595) * SDL: add multitouch support (koreader/koreader-base#1599)
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Includes: * Fix build on Mac OS X 13.3+ (missing ifr_netmask) (koreader/koreader-base#1596) * Add C declarations needed for zmq http server (koreader/koreader-base#1595) * SDL: add multitouch support (koreader/koreader-base#1599)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required by koreader to create a zmq http server
This change is