Skip to content

PB Input: Handle EV_KEY & EV_MSC translations here, instead of in front#1545

Merged
NiLuJe merged 2 commits into
koreader:masterfrom
NiLuJe:master
Oct 28, 2022
Merged

PB Input: Handle EV_KEY & EV_MSC translations here, instead of in front#1545
NiLuJe merged 2 commits into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented Oct 28, 2022

Copy link
Copy Markdown
Member

This makes PB logs one billion percent less mysterious, and actually allows cleaning up some nastiness in front.


This change is Reviewable

Comment thread input/input-pocketbook.h
* we currently fix this by making a real iv_mtinfo struct, this is dirty hack
* because of the lame API design of GetTouchInfo. It could be better to pass
* the slot paramter to GetTouchInfo which returns only one iv_mtinfo for that slot. */
* the slot parameter to GetTouchInfo which returns only one iv_mtinfo for that slot. */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parampatamparampatampemeter

@NiLuJe NiLuJe left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Frenzie)

@NiLuJe NiLuJe merged commit 3ba5085 into koreader:master Oct 28, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 28, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 28, 2022
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Oct 29, 2022
NiLuJe added a commit to koreader/koreader that referenced this pull request Oct 29, 2022
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants