[chore] thirdparty patch file dependencies#1012
Conversation
I'm going bonkers when a patch file is updated and nothing happens because only CMakeLists.txt is a dependency. This reruns CMake when any file in thirdparty/<dependency> changes. In practice that mostly means *.patch.
poire-z
left a comment
There was a problem hiding this comment.
Is the *.* (with a dot needed, and not only *) needed? Parf of Makefile/CMake way of things?
|
Just The manual doesn't seem to indicate any other way to exclude directories. https://www.gnu.org/software/make/manual/html_node/Wildcard-Function.html |
|
Do we actually need the wildcard function for a rule prerequisite? The doc seems to hint that wildcards are expanded automatically in rule prereqs. |
|
To my mind I was more or less following the example from the manual: Which example/explanation are you referring to precisely? |
|
The "print" one from https://www.gnu.org/software/make/manual/html_node/Wildcard-Examples.html |
|
D'oh, I must've overlooked that. |
8f166b7 to
3be9f9a
Compare
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes #5617.
* [chore] thirdparty patch file dependencies koreader/koreader-base#1012 * Revert "[fix] MuPDF Android font dir patch update koreader/koreader-base#1013 Fixes koreader#5617.
I'm going bonkers when a patch file is updated and nothing happens because only CMakeLists.txt is a dependency. This reruns CMake when any file in
thirdparty/<dependency>changes. In practice that mostly means*.patchin addition to CMakeLists.txt. There's acr3.cssin kpvclib and that's probably about it, but I'm trying to be forward-thinking here.