Kobo: Unbreak automagic_sysfs on the Libra 2#9998
Merged
Merged
Conversation
Regression since koreader#9902, because I'd forgotten that the default Kobo block *does* set those... Reported by @ptrm on Gitter, thanks!
Member
Author
|
Wait, that doesn't work, forgot that this is a real class with inheritance. Argh. |
We have defaults for most of those in the Kobo superclass, so these can never really be nil.
Member
Author
|
There, learned my lesson: don't try to be cute ;p. |
Frenzie
approved these changes
Jan 6, 2023
Frenzie
left a comment
Member
There was a problem hiding this comment.
Looks okay, fingers crossed and all.
Contributor
|
Checked the new As a side note, which is probably something different, Libra 2 in USBMS mode was showing battery level correctly all the time, while Clara 2e shows it's at 0% (though 2e wasn't affected by the |
Member
Author
|
@ptrm: Yup, I'd forgotten the Clara 2E bits in the USBMS tool ;o). |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Regression since koreader#9902, because I'd forgotten that the default Kobo block *does* set those... Reported by @ptrm on Gitter, thanks! Take two, essentially revert 5974425 We have defaults for most of those in the Kobo superclass, so these can never really be `nil`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression since #9902, because I'd forgotten that the default Kobo block does set those...
Reported by @ptrm on Gitter, thanks!
This change is