Fix page stats messed up after rerendering#9775
Merged
Merged
Conversation
Fix regression introduced by 48eb023: on re-rerendering, the new pages count didn't reach the Statistics plugin.
Contributor
Author
|
(Dunno how my whole first post where I usually write more funny stories ended up replacing my serious short commit message :) |
Member
|
That's how good it was. :-) |
Contributor
|
I haven't noticed it mainly because I constantly switch books via gesture :D |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Fix regression introduced by 2f749ca koreader#9651: on re-rerendering, the new pages count didn't reach the Statistics plugin. So, if you change font size or margins, the stats for the page read since then were badly accounted, until a change of book or restart... I noticed that in Book map, strange nobody else did over the last 2.5 weeks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regression introduced by 48eb023 #9651: on re-rerendering, the new pages count didn't reach the Statistics plugin.
So, if you change font size or margins, the stats for the page read since then were badly accounted, until a change of book or restart... I noticed that in Book map, strange nobody else did over the last 2.5 weeks.
(Stupid me... I explicitely put back the
return truein :onUpdateToc - as nothing else should handle that event - and just use it as-is for onDocumentRerendered, which itself should propagate...)This change is