Skip to content

Fix regression (introduced in #9657)#9759

Merged
Frenzie merged 1 commit into
masterfrom
unknown repository
Nov 7, 2022
Merged

Fix regression (introduced in #9657)#9759
Frenzie merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Nov 7, 2022

Copy link
Copy Markdown

This should fix #9741.


This change is Reviewable

@Frenzie Frenzie added this to the 2022.11 milestone Nov 7, 2022
@Frenzie

Frenzie commented Nov 7, 2022

Copy link
Copy Markdown
Member

Might also fix #9748, depending on whether I simply never noticed in two years (not impossible, we're talking about power off after all) or whether it's actually a fairly new issue.

@NiLuJe

NiLuJe commented Nov 7, 2022

Copy link
Copy Markdown
Member

@Frenzie: Nah, that's an earlier fix of mine ;).

@Frenzie Frenzie merged commit a1256f6 into koreader:master Nov 7, 2022
@ghost

ghost commented Nov 7, 2022

Copy link
Copy Markdown
Author

After a quick look, I would bet that #9748 should be fixed, too. (Tthe code cited in #9748 (comment) should not be reached as we are doing a os.execute("sleep 1 && poweroff -f &") in device.lua

@ghost ghost deleted the fixRegressionToRandomOptimizations branch November 7, 2022 15:34
@NiLuJe

NiLuJe commented Nov 7, 2022

Copy link
Copy Markdown
Member

@zwim: The sleep and backgrounding are especially there so that we do reach the exit codepaths in the startup script after an UIManager:quit ;).

@Frenzie

Frenzie commented Nov 7, 2022

Copy link
Copy Markdown
Member

There seem to be a few seconds involved though. I don't think a poweroff -f is that slow? I'll check soon.

@NiLuJe

NiLuJe commented Nov 7, 2022

Copy link
Copy Markdown
Member

It is surprisingly... weird. I originally caught it because the previous brokenness was actually attempting to restart Nickel during the poweroff, instead of exiting; and that's pretty obvious because of the boot animation (especially when it's KFMon's).

@Frenzie

Frenzie commented Nov 7, 2022

Copy link
Copy Markdown
Member

Confirmed that the behavior remains the same. Wrt my statement that it was a few seconds, I was probably counting thirds of a second. Seconds are surprisingly long really. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crashes after Power off gesture

4 participants