Skip to content

Input: Unbreak evdev handling on Kobo single-touch devices#9465

Merged
Frenzie merged 8 commits into
koreader:masterfrom
NiLuJe:master
Aug 31, 2022
Merged

Input: Unbreak evdev handling on Kobo single-touch devices#9465
Frenzie merged 8 commits into
koreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe

@NiLuJe NiLuJe commented Aug 30, 2022

Copy link
Copy Markdown
Member

I'm not entirely sure why it broke, but it was a pretty crap workaround anyway, and @pazos already had a perfectly sane setup in place for Cervantes, so let's just repurpose that ;).

Fix #9464


This change is Reviewable

@NiLuJe NiLuJe added this to the 2022.08 milestone Aug 30, 2022
@NiLuJe

NiLuJe commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

@pazos: The Cervantes bit effectively switches the C4 to the full MT codepath. Is this truly wanted and/or can you actually test it, or should I just back out the Cervantes cleanup for now?

@pazos

pazos commented Aug 30, 2022

Copy link
Copy Markdown
Member

multitouch is partially broken as is in c4, IIRC.

Probably fixable with some hooks but I don't want to try

@pazos

pazos commented Aug 30, 2022

Copy link
Copy Markdown
Member

or maybe it was broken a few years ago and now magically works?

@NiLuJe

NiLuJe commented Aug 30, 2022

Copy link
Copy Markdown
Member Author

Sooo, keep, or revert? :}

@pazos

pazos commented Aug 31, 2022

Copy link
Copy Markdown
Member

Sooo, keep, or revert? :}

revert, please :)

@NiLuJe

NiLuJe commented Aug 31, 2022

Copy link
Copy Markdown
Member Author

Re: the rM pen stuff, it's based on logs from #7536 (comment) ;).

@Frenzie Frenzie merged commit 2678d2c into koreader:master Aug 31, 2022
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
…9465)

* Kobo: Switch ST devices to a dedicated input handler

Instead of shoehorning a hack into the standard handler.

* Use setCurrentMtSlotChecked in handleTouchEvLegacy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Kobo mini: no input after OTA 202207000021

3 participants