Conversation
Author
|
Any objections to merge this? |
Member
|
IIRC, this doesn't actually touch footer code, just requests a footer
update on menu interactions, so it sounds good to me ;).
…On Thu, Jul 14, 2022, 18:00 Frans de Jonge ***@***.***> wrote:
***@***.**** approved this pull request.
Not from me, but I think @NiLuJe <https://github.com/NiLuJe> is more into
the footer?
—
Reply to this email directly, view it on GitHub
<#9325 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA3KZVW5YLDDPI4VVCF443VUA2RBANCNFSM53MRUBMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ghost
pushed a commit
that referenced
this pull request
Jul 20, 2022
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show changes from menu immediately in footer.
This change is