Skip to content

Terminal emulator: satisfy CI doc#8742

Merged
Frenzie merged 1 commit into
masterfrom
unknown repository
Jan 28, 2022
Merged

Terminal emulator: satisfy CI doc#8742
Frenzie merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jan 28, 2022

Copy link
Copy Markdown

Locally make doc works with this, maybe CI will also work?


This change is Reviewable

@ghost ghost mentioned this pull request Jan 28, 2022
@Frenzie

Frenzie commented Jan 28, 2022

Copy link
Copy Markdown
Member

As in locally first it didn't work and with this change it did?

@Frenzie Frenzie added this to the 2022.02 milestone Jan 28, 2022
@ghost

ghost commented Jan 28, 2022

Copy link
Copy Markdown
Author

With this change make doc works at least locally, before this, it did not.
So I assume it will work on CI. Anyway it is just a change in comments. Let's try.

@ghost

ghost commented Jan 28, 2022

Copy link
Copy Markdown
Author

Shall I merge it and see what happens?

@Frenzie

Frenzie commented Jan 28, 2022

Copy link
Copy Markdown
Member

I was just double checking because you made it sound like you were trying something at random. But if that's the way to interpret what you wrote then there's no "see what happens"; it'll just work. ;-)

@Frenzie Frenzie merged commit 7220bde into koreader:master Jan 28, 2022
@ghost

ghost commented Jan 28, 2022

Copy link
Copy Markdown
Author

Thanks for checking, but if I'd really try something an random, I will warn Warn WARN you :) :-)

@ghost ghost mentioned this pull request Jan 28, 2022
@ghost ghost deleted the terminalEmulatorFixDoc branch February 1, 2022 06:27
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants