Skip to content

[CI] Fix CircleCI context issue by separating out docs & translations#8614

Merged
Frenzie merged 12 commits into
koreader:masterfrom
Frenzie:circleci-stuff
Jan 4, 2022
Merged

[CI] Fix CircleCI context issue by separating out docs & translations#8614
Frenzie merged 12 commits into
koreader:masterfrom
Frenzie:circleci-stuff

Conversation

@Frenzie

@Frenzie Frenzie commented Jan 4, 2022

Copy link
Copy Markdown
Member

Still needs some script changes.

References #8607.


This change is Reviewable

@Frenzie Frenzie marked this pull request as ready for review January 4, 2022 20:20
@Frenzie Frenzie added this to the 2022.01 milestone Jan 4, 2022
@Frenzie

Frenzie commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

Merging now to prevent conflict with #8614.

@Frenzie Frenzie merged commit ec280f8 into koreader:master Jan 4, 2022
@Frenzie Frenzie deleted the circleci-stuff branch January 4, 2022 21:17
@Frenzie

Frenzie commented Jan 4, 2022

Copy link
Copy Markdown
Member Author

PS This adds an annoying extra 1:30 or so to the end of the build on the master branch, rather than nicely running in parallel.

The docs_and_coverage step ran coverage on one node, all the rest on the other. But now the docs and translations have to wait for the coverage to finish.

@poire-z

poire-z commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

The issue with the context suffered by @hius07, @zwim and others should be resolved by ec280f8.

Seems it isn't with #8616 :/

@hius07

hius07 commented Jan 5, 2022

Copy link
Copy Markdown
Member

My usual web UI workflow in my repository to make a PR:
-fetch upstream of koreader:master
-create a branch
-commit changes to the branch
-compare and make a PR to koreader:master
CircleCI doesn't start.
After merging the PR to koreader:master CircleCI starts.
Maybe I need some settings in the repository? My Actions page shows only macos_build:
https://github.com/hius07/koreader/blob/master/.github/workflows/build.yml
There is no CircleCI there.

@Frenzie

Frenzie commented Jan 5, 2022

Copy link
Copy Markdown
Member Author

https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

Sometimes you'll have a user who submits a pull request to your repository from a fork, but no pipeline will be triggered with the pull request. This can happen when the user is following the project fork on their personal account rather than the project itself on CircleCI.

This will cause the jobs to trigger under the user's personal account. If the user is following a fork of the repository on CircleCI, we will only build on that fork and not the parent, so the parent’s PR will not get status updates.

In these cases have the user unfollow their fork of the project on CircleCI and follow the source project instead. This will trigger their jobs to run under the organization when they submit pull requests.

@hius07

hius07 commented Jan 5, 2022

Copy link
Copy Markdown
Member

Great! Thanks a lot!

@Frenzie

Frenzie commented Jan 5, 2022

Copy link
Copy Markdown
Member Author

It worked? Neat! :-)

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants