Skip to content

[CI] Upgrade to new Docker image#7775

Closed
Frenzie wants to merge 9 commits into
koreader:masterfrom
Frenzie:new-docker
Closed

[CI] Upgrade to new Docker image#7775
Frenzie wants to merge 9 commits into
koreader:masterfrom
Frenzie:new-docker

Conversation

@Frenzie

@Frenzie Frenzie commented May 29, 2021

Copy link
Copy Markdown
Member

Cf. koreader/koreader-base#1375 (no dependency).


This change is Reviewable

@Frenzie Frenzie added this to the 2021.06 milestone May 29, 2021
@NiLuJe

NiLuJe commented May 29, 2021

Copy link
Copy Markdown
Member

(Busted < 2.0.0-1 is horribly broken. Hell, even that is broken, too. Ideally, we should be running scm-2 (scm-1 is broken, too), but it's not on Luarocks, only in the upstream repo).

@Frenzie

Frenzie commented May 30, 2021

Copy link
Copy Markdown
Member Author

@NiLuJe

(Busted < 2.0.0-1 is horribly broken. Hell, even that is broken, too. Ideally, we should be running scm-2 (scm-1 is broken, too), but it's not on Luarocks, only in the upstream repo).

We use(d) 2.0.0-1. It works for me locally and it's always worked. Could you expand a bit on what you think the problem is?

@Frenzie

Frenzie commented May 30, 2021

Copy link
Copy Markdown
Member Author

Actually I just realized the Docker images comes with busted preinstalled and 2.0.0-0 at that. So this is both a wasted effort and possibly futile if there's a slight hiccup somewhere.

@NiLuJe

NiLuJe commented May 30, 2021

Copy link
Copy Markdown
Member

We basically need lunarmodules/busted@2dfff99 not to horribly blow up because of our use of ffi.metatype & ffi.gc.

That isn't in anything else other than scm-2, which isn't on Luarocks.

The local versions of said hackery we used to ship are too late in the pipeline to matter, AFAICT.

(Sidebar: there's one in base as ffi_wrapper, too).

@Frenzie

Frenzie commented May 30, 2021

Copy link
Copy Markdown
Member Author

We basically need lunarmodules/busted@2dfff99 not to horribly blow up because of our use of ffi.metatype & ffi.gc.

That doesn't help though.

@NiLuJe

NiLuJe commented May 30, 2021

Copy link
Copy Markdown
Member

Then it's something else ;/. A backtrace might help.

(FWIW, I'm running scm-2 here and everything passes).

@Frenzie

Frenzie commented May 30, 2021

Copy link
Copy Markdown
Member Author

(FWIW, I'm running scm-2 here and everything passes).

As I said, everything passes regardless of the version here. ;-)

It's on CircleCI that it segfaults.

@Frenzie Frenzie modified the milestones: 2021.09, 2021.10 Sep 11, 2021
Frenzie added a commit to Frenzie/virdevenv that referenced this pull request Oct 6, 2021
@Frenzie Frenzie modified the milestones: 2021.10, 2021.11 Oct 14, 2021
@Frenzie Frenzie modified the milestones: 2021.11, 2021.12 Nov 14, 2021
@Frenzie Frenzie modified the milestones: 2021.12, 2022.01 Dec 18, 2021
@Frenzie Frenzie modified the milestones: 2022.01, 2022.02 Jan 11, 2022
@Frenzie Frenzie mentioned this pull request Jan 28, 2022
@Frenzie Frenzie modified the milestones: 2022.02, 2022.03 Feb 20, 2022
@Frenzie Frenzie modified the milestones: 2022.03, 2022.04 Mar 16, 2022
Frenzie added a commit to Frenzie/koreader that referenced this pull request Apr 15, 2022
@Frenzie Frenzie removed this from the 2022.04 milestone Apr 15, 2022
@Frenzie Frenzie closed this Apr 15, 2022
@Frenzie Frenzie deleted the new-docker branch April 15, 2022 15:34
Frenzie added a commit that referenced this pull request May 31, 2022
rjd22 pushed a commit that referenced this pull request Nov 7, 2022
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants