LuaJIT on Android fixes#7094
Merged
Merged
Conversation
Frenzie
approved these changes
Dec 31, 2020
Comment on lines
+1133
to
+1137
| if [ -n "${KODEBUG}" ]; then | ||
| adb logcat 'KOReader:* ActivityManager:* AndroidRuntime:* DEBUG:* *:F dlopen:* LuaJIT:*' | ||
| else | ||
| adb logcat 'KOReader:I ActivityManager:* AndroidRuntime:* DEBUG:* *:F' | ||
| fi |
Member
There was a problem hiding this comment.
You sure the distinction's useful?
Member
Author
There was a problem hiding this comment.
KOReader's own debug output is already fairly verbose, and so is dlopen, so, we probably don't want to bother unsuspecting users with it ;).
Member
There was a problem hiding this comment.
Unsuspecting users are running kodev run android --no-debug? :-P
Member
Author
There was a problem hiding this comment.
That's the other way around, the default is the less verbose version ^^.
e.g., kodev log android vs. kodev log -d android
Member
There was a problem hiding this comment.
Oh, right. The impact will be extremely minimal regardless.
(Again ;p). And allow disabling the C blitter, to put the workaround to the test...
Catches KOReader's debug, as well as (our) dlopen & luajit logging
d80f9c3 to
08454d8
Compare
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
* Don't flag Android as should_restrict_JIT And allow disabling the C blitter, to put the workaround to the test... * Add a -d, --debug flag to the log function Catches KOReader's debug, as well as (our) dlopen & luajit logging * Bump android-luajit-launcher koreader/android-luajit-launcher#283 koreader/android-luajit-launcher#282 * Bump base (koreader/koreader-base#1279)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires koreader/android-luajit-launcher#283 & koreader/koreader-base#1279
Make it a real boy, i.e.:
should_restrict_JITTweak kodev to add a -d, --debug flag to log to catch the extra logging added in debug builds for LuaJIT.
This change is