Skip to content

KOSync improvements#6733

Merged
Frenzie merged 5 commits into
koreader:masterfrom
Galunid:kosync-improvement
Oct 2, 2020
Merged

KOSync improvements#6733
Frenzie merged 5 commits into
koreader:masterfrom
Galunid:kosync-improvement

Conversation

@Galunid

@Galunid Galunid commented Sep 30, 2020

Copy link
Copy Markdown
Member

If user manually triggered update, allow for automatically enabling WiFi, add new menu entry "Sync every # pages", so users don't have to rely on modifying defaults.lua.persistent and set global variable DAUTO_SAVE_PAGING_COUNT. It won't break like #6489, because we check if user triggered the update. Some discussion in https://github.com/koreader/koreader/issues/6726#issuecomment-700679676. It should be alright, but I'll go over it once again after I get some sleep ;P


This change is Reviewable

Comment thread plugins/kosync.koplugin/main.lua
@Galunid Galunid marked this pull request as ready for review October 1, 2020 09:55
@Galunid Galunid requested a review from Frenzie October 1, 2020 13:58
@Frenzie Frenzie added this to the 2020.10 milestone Oct 1, 2020
Comment thread plugins/kosync.koplugin/main.lua Outdated
Comment thread plugins/kosync.koplugin/main.lua Outdated
Comment thread plugins/kosync.koplugin/main.lua Outdated
@Galunid Galunid requested a review from Frenzie October 2, 2020 06:31
@Frenzie Frenzie merged commit 8761181 into koreader:master Oct 2, 2020
@Galunid Galunid deleted the kosync-improvement branch October 2, 2020 06:54
NiLuJe added a commit that referenced this pull request Jul 2, 2023
…ore reliable (#10605)

Fix: #10539, and for context #6489, #6733, #6534

Reorganize and reword most of the settings to make it clear what actually ties into auto sync, and what doesn't. (Specifically, what happens when a pull attempts to sync forward or backward has nothing to do with auto sync, it applies in all cases; while the periodic sync *does* require auto sync).

The main point of contention, though, is that auto sync will now *always* attempt to setup network connectivity (i.e., on resume/suspend/close). Periodic sync will *not* though (the intent being that, if you use periodic sync, you're relying on the activity check to actually keep wifi on at all times)).

Since this may lead to a large amount of nagging about wifi toggles on devices w/ NetworkManager support, it is now *disabled* by default on those devices. (And given that it wouldn't have worked because of the lack of connectivity, that doesn't really make any practical difference ;p).

Additionally, given the fact that there's no way to make this behavior viable if the "before wifi" action is left at its default of "prompt", this feature now *requires* that to be set to "turn_on" (on devices where it can, of course); attempting to toggle it on will warn about that if necessary.
This change is retroactive (OTM).

Includes an assortment of fixes and cleanups, including migrating to the new LuaSettings API, which is why there's no longer a smattering of superfluous flushes.
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
* KOSync - allow automatic WiFi enabling, when user requested progress update

* Add "Sync every # pages" setting to menu

* Get rid of unused default variable

* Simplify logic
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
…ore reliable (koreader#10605)

Fix: koreader#10539, and for context koreader#6489, koreader#6733, koreader#6534

Reorganize and reword most of the settings to make it clear what actually ties into auto sync, and what doesn't. (Specifically, what happens when a pull attempts to sync forward or backward has nothing to do with auto sync, it applies in all cases; while the periodic sync *does* require auto sync).

The main point of contention, though, is that auto sync will now *always* attempt to setup network connectivity (i.e., on resume/suspend/close). Periodic sync will *not* though (the intent being that, if you use periodic sync, you're relying on the activity check to actually keep wifi on at all times)).

Since this may lead to a large amount of nagging about wifi toggles on devices w/ NetworkManager support, it is now *disabled* by default on those devices. (And given that it wouldn't have worked because of the lack of connectivity, that doesn't really make any practical difference ;p).

Additionally, given the fact that there's no way to make this behavior viable if the "before wifi" action is left at its default of "prompt", this feature now *requires* that to be set to "turn_on" (on devices where it can, of course); attempting to toggle it on will warn about that if necessary.
This change is retroactive (OTM).

Includes an assortment of fixes and cleanups, including migrating to the new LuaSettings API, which is why there's no longer a smattering of superfluous flushes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants