[Kindle] More accurate on/off FL detection/toggle#5989
[Kindle] More accurate on/off FL detection/toggle#5989NiLuJe merged 7 commits intokoreader:masterfrom
Conversation
Either fix koreader#5986, or break a whole crapload of weird corner-cases. Possibly the insane AutoFrontLight checks.
|
Sidebar: our peculiar handling of "0 == off" on <= PW3 effectively renders the lowest "on" step (0) unusable in KOReader, since we coopt it to mean off instead of whatever it does on its own. That's visible when you suspend/resume, as the system will restore the light to its own interpretation of "0" before we stomp it back to "off" ourselves. On those devices, our own lowest "on" step is "1" instead (and it matches the system's 1 insead of the system's 0). Just mentioning it for posterity's sake. I don't intend to fix it, and I wouldn't really know how best to go about it without a bunch of madness-inducing indirection layers like on Kobo. EDIT: Meh, fixed it :D. |
By fudging an extra step on our own side. Also add some debug logging around wmctrl to try to figure out what's happening there...
|
@hius07: You mentioned that the PW3 was the last device where 0 wasn't off for the FL. Does that apply to the Oasis, too (chronologically, it should not, as the Oasis was released later), but I honestly don't remember ;). |
|
Random drive-by fix for the fbink part of #5758 I'd actually forgot to update the tar progress bar calls to point to the fbink copy >_<". |
* Kindle FL shenanigans Either fix koreader#5986, or break a whole crapload of weird corner-cases. Possibly the insane AutoFrontLight checks. * Make fl step 0 usable on devices where 0 doesn't turn the light off. By fudging an extra step on our own side. * Also, add some debug logging around wmctrl to try to figure out what's happening there...
Fix #5986
Probably breaks a bunch of random and weird corner-cases (Auto FrontLight plugin?). Meh.
This change is