Highlights: turn page when start or end crosses pages#5984
Merged
poire-z merged 1 commit intokoreader:masterfrom Mar 20, 2020
Merged
Highlights: turn page when start or end crosses pages#5984poire-z merged 1 commit intokoreader:masterfrom
poire-z merged 1 commit intokoreader:masterfrom
Conversation
More generally: switch to the page that contains the highlight edge that we are currently moving.
Frenzie
approved these changes
Mar 20, 2020
Member
Frenzie
left a comment
There was a problem hiding this comment.
Looks sane enough, didn't test
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
More generally: switch to the page that contains the highlight edge that we are currently moving.
|
multi page highlighting never worked that well for me before, but you've gone and fixed it with #5984 .. i really have no idea how you can improve this app anymore but you folks keep finding ways! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More generally: switch to the page that contains the highlight edge that we are currently moving.
Closes #5973.
This change is