Skip to content

Unbreak nightmode on Cervantes#5966

Merged
pazos merged 2 commits intokoreader:masterfrom
NiLuJe:master
Mar 16, 2020
Merged

Unbreak nightmode on Cervantes#5966
pazos merged 2 commits intokoreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe
Copy link
Copy Markdown
Member

@NiLuJe NiLuJe commented Mar 15, 2020

Regression after koreader/koreader-base#1047 (I
thought it was already implemented).

Fix #5963


This change is Reviewable

Regression after koreader/koreader-base#1047 (I
thought it was already implemented).

Fix koreader#5963
Copy link
Copy Markdown
Contributor

@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not much familiar with all that, but looks allright :)

@Frenzie Frenzie added this to the 2020.04 milestone Mar 15, 2020
@Frenzie Frenzie added the bug label Mar 15, 2020
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too, dunno about the hardware specifics of Cervantes :-)

Copy link
Copy Markdown
Member

@pazos pazos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thank you!

@pazos pazos merged commit 4a5a2eb into koreader:master Mar 16, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
* Unbreak nightmode on Cervantes

Regression after koreader/koreader-base#1047 (I
thought it was already implemented).

Fix koreader#5963

* make luacheck happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cervantes: night mode doesn't work

4 participants