More compact dictionary download window#5960
Merged
Frenzie merged 2 commits intokoreader:masterfrom Mar 15, 2020
Merged
Conversation
…e and fit 3x complete dictionary selections on one page (Kindle PW3)
Frenzie
reviewed
Mar 15, 2020
Member
Frenzie
left a comment
There was a problem hiding this comment.
Sure, that should work. On many devices the current layout would nicely fit on one screen, except then you'd be missing a line on subsequent pages. (But that was rare.)
| local kv_pairs = {} | ||
| table.insert(kv_pairs, {_("Tap dictionary name to download"), ""}) | ||
| table.insert(kv_pairs, "----------------------------") | ||
| -- table.insert(kv_pairs, {_("Tap dictionary name to download"), ""}) |
Member
There was a problem hiding this comment.
Could you also remove the commented lines? ^_^
Frenzie
approved these changes
Mar 15, 2020
poire-z
approved these changes
Mar 15, 2020
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
Dictionary download window: combine the first two titles to save space and fit 3x complete dictionary selections on one page (Kindle PW3) Closes koreader#5955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5955
So I just combined the first two titles on the first page. This saves space and allows three complete dictionary entries to fit one page. This works on Kindle PW3, I don't know about other screens.
Please have a look:
This change is