Skip to content

[fix] Support proper local links#5945

Merged
Frenzie merged 2 commits intokoreader:masterfrom
Frenzie:link-fix
Mar 13, 2020
Merged

[fix] Support proper local links#5945
Frenzie merged 2 commits intokoreader:masterfrom
Frenzie:link-fix

Conversation

@Frenzie
Copy link
Copy Markdown
Member

@Frenzie Frenzie commented Mar 13, 2020

Only one style was supported. The new behavior mimics Firefox.

The following incorrect varieties will be treated the same as the correct file:///tmp/test.txt.

  • file:/tmp/test.txt
  • file://tmp/test.txt

Fixes #5941.

See #5941 (comment) for discussion.


This change is Reviewable

Only borked ones were supported. The new behavior mimics Firefox.

The following incorrect varieties will be treated the same as the correct `file:///tmp/test.txt`.
* file:/tmp/test.txt
* file://tmp/test.txt

Fixes <koreader#5941>.

See <koreader#5941 (comment)> for discussion.
@Frenzie Frenzie added the bug label Mar 13, 2020
@Frenzie Frenzie added this to the 2020.04 milestone Mar 13, 2020
@Frenzie Frenzie modified the milestones: 2020.04, 2020.03.2 Mar 13, 2020
@Frenzie Frenzie merged commit ad0a7ed into koreader:master Mar 13, 2020
@Frenzie Frenzie deleted the link-fix branch March 13, 2020 11:13
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
Only one style was supported.

Fixes <koreader#5941>.

See <koreader#5941 (comment)> for discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relative filepath to local file broken in PDF

2 participants