[Kindle] Hide the status bar on current FW, too.#5943
[Kindle] Hide the status bar on current FW, too.#5943NiLuJe merged 9 commits intokoreader:masterfrom
Conversation
Not actually usable in practice, as the standard suspend/resume routine also uses it to disable refreshes when sleeping. Which means it reenables it on resume, and screws us over.
|
That said, if we're all amenable to shipping a pre-compiled 34KB binary (it depends on X11, would be slightly hellish to build), I can fix it "properly" by telling the WM to basically make the status bar go sit in a corner. |
|
Hmm, it's (wmctrl) not perfect either, it makes the WM timeout when it attempts to refresh... Which happens on exit, or on suspend/resume on SO devices :/. (That translates in a few seconds hang before finally doing a flashing refresh). TL;DR: Meh. |
Would this fix the clock bleeding issue on later firmware >= 5.11? |
PS Obviously maintainability is a much larger concern than 30 kB more or less. ^_^ |
|
@yparitcher: When does it happen, exactly? (And I assume you're not using a Special Offers device?). (I've got a binary, that's not the issue, but thanks ;)). @Frenzie: It's unlikely to ever be updated again, anyway ^^ (it was last updated in... 2005). |
This reverts commit 55b5eb7.
At least on a non-SO device. But it's still problematic, as it breaks lipc to winmgr, which we need for orientation stuff.
mostly once in a while when changing/refreshing pages, the clock or wifi icon from kindle bleed into koreader as reported in #5022 and others. (the device is technically SO, but never connected to amazon so it does not know it, so it runs like a regular device.)
thanks, I just managed to build it, after finding the right libs and headers from my kindle. the "wmctrl -r L:C_N:titleBar_ID:system -b toggle,hidden" command works on 5.11 |
|
@yparitcher: Does it get detected as such by KOReader (i.e., do you get the stock screensavers, or ours?). Just for kicks, because twobob's binary is a wee bit old, I'm currently running a BR build of it, because I'm lazy, and it supports crosstool-ng toolchains, so I'll let it handle the mess that is building the X11 depchain ;p. |
the SS hack works fine, i can also get koreader SS. I happen to have them set to "do nothing" and running my own screensavers with https://github.com/yparitcher/kindle-zmanim
i downloaded wmctrl from http://tripie.sweb.cz/utils/wmctrl/ and built it against the X libraries from my kindle, with headers from the kindle sources and old ubuntu packages. edit: this is on a KT4 |
|
If you dont want to maintain a build, Maybe add a check in the startup script, if the user has wmctrl in the PATH then run it, and leave it up to the user to get it. |
|
It's 30KB, I'm just going to ship a K5 binary everywhere ;). |
|
mine is 26KB after stripping ;) "modern" libraries are so much smaller :) |
|
Indeed it is, twobob's binary probably wasn't stripped ;). |
|
I'd simplify all the mess and just use wmctrl everywhere, but I'm too lazy to check how it behaves on older FWs :D. |
|
Note that as I said last night, I went with a hard resize instead of the minimize, because otherwise it was tripping a timeout when ligl couldn't find the titlebar, which was triggering an unsightly stall and extra flash on suspend/resume (at least). |
|
Your branch works on my KT4 5.11. resizing instead of hiding the status bar has the side effect of the stock UI shifting up while koreader loads :) |
|
Yep. I don't actually remember how it behaved back when the soft hide command worked ;). I suppose it did the same thing, because the winmgr visibility event (which I cannot manage to fire manually outside of winmgr) appears to still be doing that? Eh. At least it makes the refresh very visible, which should take care of the "oh, no, I left wifi on" concern ;). |
I don't know if it makes sense, but at least it's consistent with the other version branches...
|
PW2, nightly v2020.03.2-9 |
|
just want to say that this doe fix the stock clock from showing. a month later and i have not seen the clock once. |
That was probably not a great idea, since we live inside a stock-UI controlled window? I dunno, I don't use KPVBooklet ;p.
Also comment on an unsuccessful experiment re: https://www.mobileread.com/forums/showthread.php?t=328015
This change is