Skip to content

[Kindle] Hide the status bar on current FW, too.#5943

Merged
NiLuJe merged 9 commits intokoreader:masterfrom
NiLuJe:master
Mar 15, 2020
Merged

[Kindle] Hide the status bar on current FW, too.#5943
NiLuJe merged 9 commits intokoreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe
Copy link
Copy Markdown
Member

@NiLuJe NiLuJe commented Mar 13, 2020

That was probably not a great idea, since we live inside a stock-UI controlled window? I dunno, I don't use KPVBooklet ;p.

Also comment on an unsuccessful experiment re: https://www.mobileread.com/forums/showthread.php?t=328015


This change is Reviewable

NiLuJe added 2 commits March 13, 2020 02:57
Not actually usable in practice, as the standard suspend/resume routine
also uses it to disable refreshes when sleeping.

Which means it reenables it on resume, and screws us over.
@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

That said, if we're all amenable to shipping a pre-compiled 34KB binary (it depends on X11, would be slightly hellish to build), I can fix it "properly" by telling the WM to basically make the status bar go sit in a corner.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

Hmm, it's (wmctrl) not perfect either, it makes the WM timeout when it attempts to refresh... Which happens on exit, or on suspend/resume on SO devices :/.

(That translates in a few seconds hang before finally doing a flashing refresh).

TL;DR: Meh.

Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't really judge. :-)

@Frenzie Frenzie added the Kindle label Mar 13, 2020
@Frenzie Frenzie added this to the 2020.04 milestone Mar 13, 2020
@yparitcher
Copy link
Copy Markdown
Member

That said, if we're all amenable to shipping a pre-compiled 34KB binary (it depends on X11, would be slightly hellish to build), I can fix it "properly" by telling the WM to basically make the status bar go sit in a corner.

Would this fix the clock bleeding issue on later firmware >= 5.11?
if so could i just build it against the x11 libs on my device?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 13, 2020

would be slightly hellish to build

PS Obviously maintainability is a much larger concern than 30 kB more or less. ^_^

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

@yparitcher: When does it happen, exactly? (And I assume you're not using a Special Offers device?).

(I've got a binary, that's not the issue, but thanks ;)).

@Frenzie: It's unlikely to ever be updated again, anyway ^^ (it was last updated in... 2005).

NiLuJe added 4 commits March 13, 2020 17:43
At least on a non-SO device.

But it's still problematic, as it breaks lipc to winmgr, which we need
for orientation stuff.
@yparitcher
Copy link
Copy Markdown
Member

yparitcher commented Mar 13, 2020

@yparitcher: When does it happen, exactly? (And I assume your not using a Special Offers device?).

mostly once in a while when changing/refreshing pages, the clock or wifi icon from kindle bleed into koreader as reported in #5022 and others. (the device is technically SO, but never connected to amazon so it does not know it, so it runs like a regular device.)

(I've got a binary, that's not the issue, but thanks ;)).

thanks, I just managed to build it, after finding the right libs and headers from my kindle.

the "wmctrl -r L:C_N:titleBar_ID:system -b toggle,hidden" command works on 5.11
in a few days i can let you know if it stops the clocks bleeding.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

@yparitcher: Does it get detected as such by KOReader (i.e., do you get the stock screensavers, or ours?).

Just for kicks, because twobob's binary is a wee bit old, I'm currently running a BR build of it, because I'm lazy, and it supports crosstool-ng toolchains, so I'll let it handle the mess that is building the X11 depchain ;p.

@yparitcher
Copy link
Copy Markdown
Member

yparitcher commented Mar 13, 2020

@yparitcher: Does it get detected as such by KOReader (i.e., do you get the stock screensavers, or ours?).

the SS hack works fine, i can also get koreader SS. I happen to have them set to "do nothing" and running my own screensavers with https://github.com/yparitcher/kindle-zmanim

Just for kicks, because twobob's binary is a wee bit old, I'm currently running a BR build of it, because I'm lazy, and it supports crosstool-ng toolchains ;p.

i downloaded wmctrl from http://tripie.sweb.cz/utils/wmctrl/ and built it against the X libraries from my kindle, with headers from the kindle sources and old ubuntu packages.

edit: this is on a KT4

@yparitcher
Copy link
Copy Markdown
Member

If you dont want to maintain a build, Maybe add a check in the startup script, if the user has wmctrl in the PATH then run it, and leave it up to the user to get it.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

It's 30KB, I'm just going to ship a K5 binary everywhere ;).

@yparitcher
Copy link
Copy Markdown
Member

yparitcher commented Mar 13, 2020

mine is 26KB after stripping ;)

"modern" libraries are so much smaller :)

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

Indeed it is, twobob's binary probably wasn't stripped ;).

@NiLuJe NiLuJe changed the title Don't stop the WM when using KPVBooklet [Kindle] Hide the status bar on current FW, too. Mar 13, 2020
@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

I'd simplify all the mess and just use wmctrl everywhere, but I'm too lazy to check how it behaves on older FWs :D.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

Note that as I said last night, I went with a hard resize instead of the minimize, because otherwise it was tripping a timeout when ligl couldn't find the titlebar, which was triggering an unsightly stall and extra flash on suspend/resume (at least).

@yparitcher
Copy link
Copy Markdown
Member

Your branch works on my KT4 5.11.

resizing instead of hiding the status bar has the side effect of the stock UI shifting up while koreader loads :)

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Mar 13, 2020

Yep. I don't actually remember how it behaved back when the soft hide command worked ;).

I suppose it did the same thing, because the winmgr visibility event (which I cannot manage to fire manually outside of winmgr) appears to still be doing that? Eh.

At least it makes the refresh very visible, which should take care of the "oh, no, I left wifi on" concern ;).

I don't know if it makes sense, but at least it's consistent with the
other version branches...
@NiLuJe NiLuJe merged commit 9ce22f5 into koreader:master Mar 15, 2020
@hius07
Copy link
Copy Markdown
Member

hius07 commented Mar 19, 2020

PW2, nightly v2020.03.2-9
Upon exit from KOReader status bar always displays correct state of Aeroplane mode.
Perfectly, thanks a lot.

@yparitcher
Copy link
Copy Markdown
Member

just want to say that this doe fix the stock clock from showing.

a month later and i have not seen the clock once.
Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants