Skip to content

Make xpointers migration ConfirmBox non-dismissable#5931

Merged
poire-z merged 1 commit intokoreader:masterfrom
poire-z:xp_migration_non_dismissable
Mar 8, 2020
Merged

Make xpointers migration ConfirmBox non-dismissable#5931
poire-z merged 1 commit intokoreader:masterfrom
poire-z:xp_migration_non_dismissable

Conversation

@poire-z
Copy link
Copy Markdown
Contributor

@poire-z poire-z commented Mar 8, 2020 •
edited by Frenzie
Loading

Because dismissing it by tapping outside would have "not for this book" selected, which is the least welcome action...
Details at #5897 (comment).

This change is Reviewable

@poire-z
Make xpointers migration ConfirmBox non-dismissable
b5b678e 
Because dismissing it by tapping outside would have
"not for this book" selected, which is the least
welcome action.
@Frenzie Frenzie added this to the 2020.03.1 milestone Mar 8, 2020
@poire-z poire-z merged commit c1f19e9 into koreader:master Mar 8, 2020
@poire-z poire-z deleted the xp_migration_non_dismissable branch March 8, 2020 19:22
@ptrm
Copy link
Copy Markdown
Contributor

ptrm commented Mar 9, 2020

And having dismissed it for one book, how to get xpointers migrated anyway :D ?

@poire-z
Copy link
Copy Markdown
Contributor Author

poire-z commented Mar 9, 2020

sorry :|
Just edit metadata.epub.lua for this book, and remove the line:

["cre_keep_old_dom_version"] = true,

and re-open the book: you'll get tha ConfirmBox again.

@poire-z
Copy link
Copy Markdown
Contributor Author

poire-z commented Mar 12, 2020

@Frenzie : I see you've made a 2020.03.1 yesterday (thanks!), but there's no binary asset uploaded.
I also see there's been 4 or 5 pipeline runs yesterday outside regular nightlies :) any problem ?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 12, 2020

It's not picking up on the tag, not sure why, the result is exactly the same for all intents and purposes but it gives an uglier filename/version number.

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 12, 2020

Actually it looks like doing it through the GH web GUI doesn't do an annotated tag. /sigh

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Mar 12, 2020 •
edited
Loading

So yeah, what's wrong is that GH is pretty useless if you aren't at your regular PC with proper command-line Git.

I thought there was a cache involved somewhere, is all.

mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
@poire-z @mwoz123
Make xpointers migration ConfirmBox non-dismissable (koreader#5931)
adab8b9 
Because dismissing it by tapping outside would have
"not for this book" selected, which is the least
welcome action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

bug UX

Projects

None yet

Milestone

2020.03.1

Development

Successfully merging this pull request may close these issues.

3 participants

@poire-z @ptrm @Frenzie