Skip to content

Unbreak the KUAL extension#5715

Merged
NiLuJe merged 6 commits intokoreader:masterfrom
NiLuJe:master
Dec 31, 2019
Merged

Unbreak the KUAL extension#5715
NiLuJe merged 6 commits intokoreader:masterfrom
NiLuJe:master

Conversation

@NiLuJe
Copy link
Copy Markdown
Member

@NiLuJe NiLuJe commented Dec 31, 2019

Nasty symlink shenanigans meant we weren't actually shipping a required script...

Also, unclutter it while I'm here ;).


This change is Reviewable

@NiLuJe NiLuJe requested a review from Frenzie as a code owner December 31, 2019 14:45
@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Dec 31, 2019

(Waiting on CI to double-check that I haven't borked the symlink).

On the odd-chance someone's running an horrendously old bridge
We've had an in-UI setting for those since approximately half a billion
years.
Symlink inot a symlink that actually points to a real path.
My brain hurts.
update_koreader "clean"
}

# Handle cre's settings...
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What even is all this? Some vestigial thing from 2011? >_>

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, reaaaaaallly old stuff ^^.

Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but I don't really know what the deleted parts are even for.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Dec 31, 2019

@Frenzie: Any idea why the CI is only now complaining about not having ragel to build HB from git?

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Dec 31, 2019

Some failed download? That's… pretty weird.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Dec 31, 2019

No, it tried to regenerate some headers (which I think actually are shipped in the git repo, so, some kind of timestamp mishap?).

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Dec 31, 2019

Just rerun it?

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Dec 31, 2019

Just remembered that front's CI only does an emulator build, so, running a local kindle build to double-check ;p.

@NiLuJe
Copy link
Copy Markdown
Member Author

NiLuJe commented Dec 31, 2019

  adding: extensions/koreader/bin/libkohelper.sh (deflated 53%)

Wheee!

@NiLuJe NiLuJe added this to the 2020.01 milestone Dec 31, 2019
@NiLuJe NiLuJe merged commit 47da0ae into koreader:master Dec 31, 2019
@NiLuJe NiLuJe mentioned this pull request Jan 10, 2020
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
* Prefer our own FBInk binary
* Get rid of the CRe config tweaks
* Oops, actually ship libkohelper in the KUAL extension.
* Bump extension version
* Flush to disk before printing final status message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants