fix continuous scroll & footer overlap#5657
Conversation
|
@robert00s Could you take a look and test as well? It seems fine to me but I don't know all the ins and outs of the mini statusbar. |
|
(I was willing to have a go at testing this, but I can't reproduce the issue before applying this PR :) I always get some overlap... Note that I'm not really familiar with our PDF/CBZ/ReaderPaging code and options...) Anyway, should we merge this, and let users test it? :) |
|
Overlap is supposed to be there; tbh I never understand any of these issues because there's plenty. Scroll mode will be cut off for obvious reasons; paged won't. Usually you'll get a nice full line on the next page, sometimes you won't. Margin stuff is completely unrelated, but theoretically you could detect lines and make sure(r). |
|
Anyway, the "issue" is that some overlap is eaten by the status bar. But imo the issue is the reverse if anything. |
|
That is, the overlap is rather large, basically good with statusbar and oversized without. So I'd combine this PR with reduced overlap. |
|
I'm also not familiar with CBZ ReaderPaging. |
|
the issue is not so much the overlap rather the the end of a "page" is cut off due to being under the footer.
with `page` view it is every page
with `continous view` it is only at the end of the document
the efect is more when using a width based zoom.
this pr should just put the status bar area out of the margin, so it is not used in calculating how much of the page to show.
|
closes koreader#5654 like koreader#5620 but for continuous mode.
closes #5654
like #5620 but for continuous mode.
may fail CI because the page sizes change.needs testing for side effects.
This change is