Skip to content

Remove DRCOUNTMAX#5644

Merged
poire-z merged 1 commit intokoreader:masterfrom
robert00s:DRCOUNTMAX
Nov 26, 2019
Merged

Remove DRCOUNTMAX#5644
poire-z merged 1 commit intokoreader:masterfrom
robert00s:DRCOUNTMAX

Conversation

@robert00s
Copy link
Copy Markdown
Contributor

@robert00s robert00s commented Nov 26, 2019 •
edited by Frenzie
Loading

DRCOUNTMAX in Advanced settings is no longer needed.

-- number of page turns between full screen refresh
-- default to do a full refresh on every 6 page turns
--DRCOUNTMAX = 6

Full refresh can be modified in Settings -> Screen -> E-ink settings -> Full refresh rate

This change is Reviewable

@robert00s robert00s added this to the 2019.12 milestone Nov 26, 2019
@poire-z
Copy link
Copy Markdown
Contributor

poire-z commented Nov 26, 2019

More to come, to be added to this PR ? or you prefer one by one?

@robert00s
Copy link
Copy Markdown
Contributor Author

robert00s commented Nov 26, 2019

I plan to remove defaults completely. Some settings will be removed, some will be moved to the menu in different places and others will create new advanced settings with submenu.
It's a lot of work so I want to do it one by one.

@poire-z poire-z merged commit a96114d into koreader:master Nov 26, 2019
@poire-z
Copy link
Copy Markdown
Contributor

poire-z commented Nov 26, 2019

OK.
But I don't know if it's really desirable for some settings.
For example:

koreader/defaults.lua

Lines 117 to 127 in 5a28cbd

-- crereader margin sizes
-- horizontal margins {left, right} in (relative) pixels
DCREREADER_CONFIG_H_MARGIN_SIZES_SMALL = {5, 5}
DCREREADER_CONFIG_H_MARGIN_SIZES_MEDIUM = {10, 10}
DCREREADER_CONFIG_H_MARGIN_SIZES_LARGE = {15, 15}
DCREREADER_CONFIG_H_MARGIN_SIZES_X_LARGE = {20, 20}
DCREREADER_CONFIG_H_MARGIN_SIZES_XX_LARGE = {30, 30}
DCREREADER_CONFIG_H_MARGIN_SIZES_XXX_LARGE = {50, 50}
DCREREADER_CONFIG_H_MARGIN_SIZES_HUGE = {70, 70}
DCREREADER_CONFIG_H_MARGIN_SIZES_X_HUGE = {100, 100}
DCREREADER_CONFIG_H_MARGIN_SIZES_XX_HUGE = {140, 140}

I don't want just to be able to fine-adjust the current margins of my current book, and save that as my one single default - to use it on future books.
Currently, and I had done that for the example above and its buddies, I have changed them all to values that make more sense to me, so I have 9 defaults - but they are my defaults :) - that I can tap on the bottom menu to get any of them.

If I can't edit (copy to defaults.persistent.lua) a file to tweak them, and I have to go thru some UI (which you'll have to make very complicated to allow me that), it will be tedious.

(Personally, it won't hurt me much, as I patch nightlies anyway, I'll just have to patch them in their new places in the code - but still, I guess some people like being able to edit defaults.persistent.lua for such settings and some others.)

@robert00s robert00s deleted the DRCOUNTMAX branch November 26, 2019 14:23
@robert00s
Copy link
Copy Markdown
Contributor Author

robert00s commented Nov 27, 2019

Thanks for your opinion. I'm not a big fan of defaults but if people want to use defaults file I will leave it. We back to it later.
One for sure. I want to rebuild advanced settings.

mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
@robert00s @mwoz123
Remove DRCOUNTMAX (koreader#5644)
5bd8a5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2019.12

Development

Successfully merging this pull request may close these issues.

3 participants

@robert00s @poire-z @Frenzie