Rewrite unicodeCodepointToUtf8 w/ bitopt#5625
Merged
NiLuJe merged 2 commits intokoreader:masterfrom Nov 22, 2019
Merged
Conversation
Avoids costly divs & modulos
Member
Author
|
Random optimization because I noticed I had a copy of that in C lying around in FBInk ;p. |
Member
Author
|
(We can't use the unsigned wraparound trickery from the first ref. for the surrogates test because Lua :/). |
Frenzie
approved these changes
Nov 22, 2019
Member
Frenzie
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Contributor
|
For info: https://luapower.com/luajit-notes
|
poire-z
approved these changes
Nov 22, 2019
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
* Rewrite unicodeCodepointToUtf8 w/ bitopt Avoids costly divs & modulos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids costly divs & modulos
This change is