Skip to content

Cloud storage UX improvements#5613

Merged
Frenzie merged 3 commits intokoreader:masterfrom
robert00s:cloud_overwrite
Nov 19, 2019
Merged

Cloud storage UX improvements#5613
Frenzie merged 3 commits intokoreader:masterfrom
robert00s:cloud_overwrite

Conversation

@robert00s
Copy link
Copy Markdown
Contributor

Two cloudstorage UX improvements:

  • Show confirmbox File already exists. Would you like to overwrite it? after tap on Download file not before tap in situation when file exist in local storage.

  • Show confirmbox File saved to: (...). Would you like to read the downloaded book now? instead of File saved to:... when file is supported and when we have choosen Show unsupported files .

@robert00s robert00s changed the title Cloud overwrite Cloud storage UX improvements Nov 19, 2019
@Frenzie Frenzie added this to the 2019.12 milestone Nov 19, 2019
@Frenzie Frenzie added the UX label Nov 19, 2019
Copy link
Copy Markdown
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine; didn't test

@Frenzie Frenzie merged commit e655616 into koreader:master Nov 19, 2019
@robert00s robert00s deleted the cloud_overwrite branch November 23, 2019 18:13
mwoz123 pushed a commit to mwoz123/koreader that referenced this pull request Mar 29, 2020
* Overwrite confirmbox order

* Restore confirmbox option to read the downloaded book
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants