[feat] Support callback function in VirtualKeyPopup#5588
Merged
Frenzie merged 2 commits intokoreader:masterfrom Nov 11, 2019
Merged
[feat] Support callback function in VirtualKeyPopup#5588Frenzie merged 2 commits intokoreader:masterfrom
Frenzie merged 2 commits intokoreader:masterfrom
Conversation
Required for <koreader#5583>.
poire-z
approved these changes
Nov 11, 2019
| local parent_key = self.parent_key | ||
| local key_chars = parent_key.key_chars | ||
| local key_char_orig = key_chars[1] | ||
| local key_char_orig_func = parent_key.callback |
Member
Author
There was a problem hiding this comment.
The middle button responds like the original key so I figure it should do the same with a custom callback. Could also just be nil I figure.
Contributor
There was a problem hiding this comment.
Oh, allright, I thought you were saving something before allowing/going to override it (that I often would name something_orig_func :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for #5583.